Edit report at https://bugs.php.net/bug.php?id=74918&edit=1
ID: 74918
Updated by: requi...@php.net
Reported by: graefrath at femu dot rwth-aachen dot de
Summary: Wrong ICU version comparison in some tests
-Status: Open
+Status: Feedback
Type: Bug
Package: Testing related
Operating System: Oracle Linux 6
PHP Version: 5.6.31
Block user comment: N
Private report: N
New Comment:
(If anyone is wondering about the versioning, apparently libicu changed schemes
and went from 4.6 to 49. So 4.2.1 â 42.1 and 50.1.2 â 5.0.1.2.)
if (version_compare(INTL_ICU_VERSION, '50.1.2') >= 0) die('skip for ICU <
50.1.2');
Note that the leading "skip" in the die() message is a technical requirement
and not necessarily meant to be read as part of the reason (though it often is).
https://qa.php.net/write-test.php#skipif
Either
a) The code is right (skip >= 50.1.2) and the message means the test only
applies to < 50.1.2, or
b) The comment is right (skip < 50.1.2) and the code is backwards
I think the former is more likely.
How are the tests failing?
Previous Comments:
------------------------------------------------------------------------
[2017-07-13 11:44:14] graefrath at femu dot rwth-aachen dot de
Description:
------------
While running make test the tests
- dateformat_create_cal_arg.phpt
- dateformat_formatObject_calendar.phpt
- dateformat_formatObject_datetime.phpt
- dateformat_get_set_calendar.phpt
- dateformat_get_set_timezone.phpt
- msgfmt_format_intlcalendar.phpt
execute and fail, even though they should have been skipped. My ICU version is
4.2.1, the tests are supposed to be skipped if the ICU version is < 51.2.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=74918&edit=1
--
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php
