Edit report at https://bugs.php.net/bug.php?id=74918&edit=1
ID: 74918
User updated by: graefrath at femu dot rwth-aachen dot de
Reported by: graefrath at femu dot rwth-aachen dot de
Summary: Wrong ICU version comparison in some tests
-Status: Feedback
+Status: Open
Type: Bug
Package: Testing related
Operating System: Oracle Linux 6
PHP Version: 5.6.31
Block user comment: N
Private report: N
New Comment:
Oh I see, I didn't know about the skip thing. I just assumed the code was
wrong. My bad! Anyway, here are the actual test diffs:
dateformat_create_cal_arg.diff:
001+ domingo 1 de enero de 2012 00:00:00 GMT+00:00
002+ domingo 8 de Safar de 1433 00:00:00 GMT+00:00
001- domingo%S 1 de enero de 2012 00:00:00 GMT
002- domingo%S 8 de Safar de 1433 00:00:00 GMT
004+ sábado 31 de diciembre de 2011 23:00:00 Hora de las Azores
005+ sábado 7 de Safar de 1433 23:00:00 Hora de las Azores
006+ domingo 8 de Safar de 1433 00:00:00 GMT+00:00
007+ domingo 1 de enero de 2012 00:00:00 GMT+00:00
004- sábado%S 31 de diciembre de 2011 d.C. 23:00:00 Hora %Sde las Azores
005- sábado%S 7 de Safar de 1433 AH 23:00:00 Hora %Sde las Azores
006- domingo%S 8 de Safar de 1433 AH 00:00:00 GMT
007- domingo%S 1 de enero de 2012 00:00:00 GMT
dateformat_formatObject_calendar.diff:
001+ 1 de Jan de 2012 00:00:00
002+ domingo, 1 de Janeiro de 2012 00h00min00s Hora da Europa Ocidental
001- 01/01/2012 00:00:00
002- Domingo, 1 de Janeiro de 2012 0:00:00 Hora %Sda Europa Ocidental
005+ Sun 2012-01-1 00,00,00.000 Portugal (Lisbon)
006+ domingo, 1 de Janeiro de 2012 05h00min00s GMT+03:00
007+ 6 de Safar de 1433 00:00:00
005- Sun 2012-01-1 00,00,00.000 Portugal Time (Lisbon)
006- Domingo, 1 de Janeiro de 2012 5:00:00 GMT+03:00
007- 06/02/1433 00:00:00
dateformat_formatObject_datetime.diff
001+ 1 de Jan de 2012 00:00:00
002+ domingo, 1 de Janeiro de 2012 00h00min00s Hora da Europa Ocidental
001- 01/01/2012 00:00:00
002- Domingo, 1 de Janeiro de 2012 0:00:00 Hora %Sda Europa Ocidental
005+ Sun 2012-01-1 00,00,00.000 Portugal (Lisbon)
006+ domingo, 1 de Janeiro de 2012 05h00min00s GMT+03:00
005- Sun 2012-01-1 00,00,00.000 Portugal Time (Lisbon)
006- Domingo, 1 de Janeiro de 2012 5:00:00 GMT+03:00
dateformat_get_set_calendar.diff:
001+ dimanche 1 janvier 2012 02:00:00 Heure normale de lâEurope de lâEst
001- dimanche 1 janvier 2012 ap. J.-C. 03:00:00 UTC+03:00
006+ dimanche 8 Safar 1433 02:00:00 Heure normale de lâEurope de lâEst
006- dimanche 8 Safar 1433 AH 03:00:00 UTC+03:00
011+ dimanche 1 janvier 2012 00:00:00 UTC+00:00
011- dimanche 1 janvier 2012 ap. J.-C. 00:00:00 UTC
dateformat_get_set_timezone.diff
001+ domingo, 1 de Janeiro de 2012 02h00min00s Hora da Europa Oriental
001- Domingo, 1 de Janeiro de 2012 3:00:00 GMT+03:00
005+ sábado, 31 de Dezembro de 2011 23h00min00s Hora dos Açores
005- Sábado, 31 de Dezembro de 2011 23:00:00 Hor%s %Sdos Açores
009+ domingo, 1 de Janeiro de 2012 01h00min00s Horário Padrão da Europa
Central
009- Domingo, 1 de Janeiro de 2012 1:00:00 Hor%s %Sda Europa Central
013+ domingo, 1 de Janeiro de 2012 01h00min00s Horário Padrão da Europa
Central
013- Domingo, 1 de Janeiro de 2012 1:00:00 Hor%s %Sda Europa Central
017+ domingo, 1 de Janeiro de 2012 01h00min00s Horário Padrão da Europa
Central
017- Domingo, 1 de Janeiro de 2012 1:00:00 Hor%s %Sda Europa Central
msgfmt_format_intlcalendar.diff:
001+ quinta-feira, 17 de Maio de 2012 5:35:36 Depois do meio-dia WEST
001- Quinta-feira, 17 de Maio de 2012 5:35:36 p.m. WEST
Previous Comments:
------------------------------------------------------------------------
[2017-07-13 13:53:37] requi...@php.net
(If anyone is wondering about the versioning, apparently libicu changed schemes
and went from 4.6 to 49. So 4.2.1 â 42.1 and 50.1.2 â 5.0.1.2.)
if (version_compare(INTL_ICU_VERSION, '50.1.2') >= 0) die('skip for ICU <
50.1.2');
Note that the leading "skip" in the die() message is a technical requirement
and not necessarily meant to be read as part of the reason (though it often is).
https://qa.php.net/write-test.php#skipif
Either
a) The code is right (skip >= 50.1.2) and the message means the test only
applies to < 50.1.2, or
b) The comment is right (skip < 50.1.2) and the code is backwards
I think the former is more likely.
How are the tests failing?
------------------------------------------------------------------------
[2017-07-13 11:44:14] graefrath at femu dot rwth-aachen dot de
Description:
------------
While running make test the tests
- dateformat_create_cal_arg.phpt
- dateformat_formatObject_calendar.phpt
- dateformat_formatObject_datetime.phpt
- dateformat_get_set_calendar.phpt
- dateformat_get_set_timezone.phpt
- msgfmt_format_intlcalendar.phpt
execute and fail, even though they should have been skipped. My ICU version is
4.2.1, the tests are supposed to be skipped if the ICU version is < 51.2.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=74918&edit=1
--
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php
