Edit report at https://bugs.php.net/bug.php?id=55671&edit=1
ID: 55671 Updated by: carusogabr...@php.net Reported by: tyr...@php.net Summary: clean up the php 6 references in run-tests.php -Status: Open +Status: Closed Type: Bug Package: Testing related PHP Version: Irrelevant -Assigned To: +Assigned To: carusogabriel Block user comment: N Private report: N New Comment: Closing as it was solved via http://git.php.net/?p=php-src.git;a=commit;h=5af586be Previous Comments: ------------------------------------------------------------------------ [2012-09-09 09:58:33] reeze dot xia at gmail dot com Yes, I'm not saying that is a php6's feature. I mean the outmost "if (PHP_MAJOR_VERSION < 6)â checking is not accurate since PHP6 is going nowhere. That checking is useful in < 5.4 but not 6 :) This issue was related to PHP6 cleanup, so I mention that here. ------------------------------------------------------------------------ [2012-09-09 09:42:15] larue...@php.net I really don't understand your point. did you read the codes carefully? it's not a php 6 specifc test, it's about to generate a warning about safe_mode. it has nothing to do with php 6. 5.2 5.3 still have safe_mode. then MAJOR_VERSOIN of them will meet that condition.. ------------------------------------------------------------------------ [2012-09-09 09:31:35] reeze dot xia at gmail dot com PHP6 didn't exist so that test was useless, as tyrael said, safe_mode have been removed with 5.4. ------------------------------------------------------------------------ [2012-09-09 09:05:29] larue...@php.net "MAJOR_VERSION < 6" has nothing to do with PHP 6, what do you expected? MAJOR_VERSION <= 5? ------------------------------------------------------------------------ [2012-09-08 14:57:11] reeze dot xia at gmail dot com Do we still have the problem? I saw only one place have php6 specific test in run-tests.php if (PHP_MAJOR_VERSION < 6) { ini_set('magic_quotes_runtime',0); // this would break tests by modifying EXPECT sections if (ini_get('safe_mode')) { echo <<< SAFE_MODE_WARNING ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=55671 -- Edit this bug report at https://bugs.php.net/bug.php?id=55671&edit=1 -- PHP Quality Assurance Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
