On Fri, 14 Dec 2018 at 22:45, Lester Caine <[email protected]> wrote: > > On 14/12/2018 21:31, Kalle Sommer Nielsen wrote: > > Den fre. 14. dec. 2018 kl. 21.12 skrev Lester Caine <[email protected]>: > >> Early strip processing removed the various options of 'new line' but > >> replacing them with a single space was not necessarily the right answer, > >> which is why many scripts have a manual space at the end of each line of > >> text. Just explaining why those spaces had originally been the correct > >> coding style. There has been a debate recently on extending from an 80 > >> character line default, and stripping line feeds to pad out a longer > >> line length may well need these spaces reinstating ... just a matter of > >> preferred coding style when working with SQL rather than other scripts. > > > > If you found a bug with the patch, then report it at bugs.php.net so > > we can look into it, if not then please keep the fuzz off the list, > > thank you > > The comment should be read in the same way as with other comments on > unnecessary changes to the code simply to address a new style of coding! > But as with other style changes much of the original rational has never > been documented at all?
Hello, the trailing whitespace (the first on the list) are actually regularly cleaned on multiple repositories. That was a just one missed leftover from the past. I've missed it then because the script to do this is not so smart yet. None SQL statements in this app will cause issues with these trailing whitespaces cleaned. Also no file in this repository needs trailing whitespace anywhere. Has been checked and we can safely say to trim all. It's a pedantic thing. Trailing whitespace doesn't belong anywhere in the code. On certain editors, the previous state of the code, these were causing constant conflicts with what to commit and what not. Most of all, these issues scare new contributors. To avoid causing unnecessary commit changes such as trimmed trailing whitespaces in these editors, this is actually a contributor friendly solution so the maintainer of the repository don't need to comment unfriendly pull requests and commits comments when this comes up. And the other way around. And it happens quite a lot of times actually. We're humans and not machines that can notice some whitespace every time just like that. One of the reasons that this is done manually from time to time if needed. That's all. -- Peter Kokot -- PHP Webmaster List Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
