Hi Lajos
On 2/25/07, Lajos Cseppentõ <[EMAIL PROTECTED]> wrote:
Hello!
I've modified a bit the phpdoc-hu Makefile script on my computer. I've added
reviewedcheck and I've created a "revchecks" option, which creates
revcheck.html and reviewedcheck.html.
Line: 125
revcheck: revcheck.html
reviewedcheck: reviewedcheck.html
revchecks: revchecks.html
[...] Line ~151:
revcheck.html: FORCE
PHPDOCDIR=$(srcdir) $(PHP) -c $(scriptdir) -f $(scriptdir)/revcheck.php
$(LANGDIR) > revcheck.html
reviewedcheck.html: FORCE
PHPDOCDIR=$(srcdir) $(PHP) -c $(scriptdir) -f
$(scriptdir)/reviewedcheck.php $(LANGDIR) > reviewedcheck.html
revchecks.html: FORCE
PHPDOCDIR=$(srcdir) $(PHP) -c $(scriptdir) -f $(scriptdir)/revcheck.php
$(LANGDIR) > revcheck.html
PHPDOCDIR=$(srcdir) $(PHP) -c $(scriptdir) -f
$(scriptdir)/reviewedcheck.php $(LANGDIR) > reviewedcheck.html
(these are tabs, right? not a single space?)
What do you think? Is it a good code (it semms it works). Should I commit
this change in Makefile.in and upload to CVS?
Sounds like a good idea to me.
Only one thing: I don't see the point of "PHPDOCDIR=", it is
meaningless (never used) and is just confusing, IMO.
Also you may want to add reviewedcheck.html into the cleaning section.
In the future, please post unified diff (cvs diff -u Makefile.in >
my.patch.txt) as it is more readable as we see the exact changes right
away...
-Hannes
Best Regards,
Lajos
