In plain text please...
On 2/25/07, Lajos Cseppento <[EMAIL PROTECTED]> wrote:
Here's the patch file.
""Hannes Magnusson"" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
Hi Lajos
On 2/25/07, Lajos Cseppentõ <[EMAIL PROTECTED]> wrote:
> Hello!
>
> I've modified a bit the phpdoc-hu Makefile script on my computer. I've
> added
> reviewedcheck and I've created a "revchecks" option, which creates
> revcheck.html and reviewedcheck.html.
>
>
> Line: 125
> revcheck: revcheck.html
> reviewedcheck: reviewedcheck.html
> revchecks: revchecks.html
>
> [...] Line ~151:
>
> revcheck.html: FORCE
> PHPDOCDIR=$(srcdir) $(PHP) -c $(scriptdir) -f $(scriptdir)/revcheck.php
> $(LANGDIR) > revcheck.html
>
> reviewedcheck.html: FORCE
> PHPDOCDIR=$(srcdir) $(PHP) -c $(scriptdir) -f
> $(scriptdir)/reviewedcheck.php $(LANGDIR) > reviewedcheck.html
>
> revchecks.html: FORCE
> PHPDOCDIR=$(srcdir) $(PHP) -c $(scriptdir) -f $(scriptdir)/revcheck.php
> $(LANGDIR) > revcheck.html
> PHPDOCDIR=$(srcdir) $(PHP) -c $(scriptdir) -f
> $(scriptdir)/reviewedcheck.php $(LANGDIR) > reviewedcheck.html
(these are tabs, right? not a single space?)
>
>
> What do you think? Is it a good code (it semms it works). Should I commit
> this change in Makefile.in and upload to CVS?
Sounds like a good idea to me.
Only one thing: I don't see the point of "PHPDOCDIR=", it is
meaningless (never used) and is just confusing, IMO.
Also you may want to add reviewedcheck.html into the cleaning section.
In the future, please post unified diff (cvs diff -u Makefile.in >
my.patch.txt) as it is more readable as we see the exact changes right
away...
-Hannes
>
> Best Regards,
> Lajos
>
begin 666 patch.chappy.txt
[EMAIL PROTECTED]($UA:V5F:6QE+FEN"CT]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T*4D-3
M(&9I;&4Z("]R97!O<VET;W)Y+W!H<&1O8R]-86ME9FEL92YI;BQV"G)E=')I
M979I;F<@<F5V:7-I;VX@,2XQ.3(*9&EF9B M=2 M=2 M<C$N,3DR($UA:V5F
M:6QE+FEN"BTM+2!-86ME9FEL92YI;@DR,"!&96(@,C P-R R,3HQ-SHS.2 M
M,# P, DQ+C$Y,@[EMAIL PROTECTED];&4N:6X),[EMAIL PROTECTED](#(P,#<@,3$Z,C8Z
M,[EMAIL PROTECTED] P,# *0$ @+3$R-"PV("LQ,C0L-R! 0 H@:&]W=&]T9WHZ(&AO=W1O
M+VAO=W1O+FAT;6PN=&%R+F=Z"B!F=6YC:[EMAIL PROTECTED](&9U;F-I;F1E>"YX;6P*
M(')E=F-H96-K.B!R979C:&5C:RYH=&UL"BMR979I97=E9&-H96-K.B!R979I
M97=E9&-H96-K+FAT;6P*( [EMAIL PROTECTED]"B *0$ @+3$U,"PV("LQ-3$L,3,@
M0$ *(')E=F-H96-K+FAT;6PZ($9/4D-%"B )4$A01$]#1$E2/20H<W)C9&ER
M*2 D*%!(4"[EMAIL PROTECTED],@)"AS8W)I<'1D:7(I("UF("0H<V-R:7!T9&ER*2]R979C
M:&5C:RYP:' @)"A,04Y'1$E2*2 ^(')E=F-H96-K+FAT;6P*( HK<F5V:65W
M961C:&5C:RYH=&UL.B!&3U)#10HK"5!(4$1/0T1)4CTD*'-R8V1I<BD@)"A0
M2% I("UC("0H<V-R:7!T9&ER*2 M9B D*'-C<FEP=&1I<BDO<F5V:65W961C
M:&5C:RYP:' @)"A,04Y'1$E2*2 ^(')E=FEE=V5D8VAE8VLN:'1M; HK"BMR
M979C:&5C:W,Z($9/4D-%"BL))"A02% I("UC("0H<V-R:7!T9&ER*2 M9B D
M*'-C<FEP=&1I<BDO<F5V8VAE8VLN<&AP("0H3$%.1T1)4BD@/B!R979C:&5C
M:RYH=&UL"BL))"A02% I("UC("0H<V-R:7!T9&ER*2 M9B D*'-C<FEP=&1I
M<BDO<F5V:65W961C:&5C:RYP:' @)"A,04Y'1$E2*2 ^(')E=FEE=V5D8VAE
M8VLN:'1M; HK"B!F=6YC:[EMAIL PROTECTED]>&UL.B!&3U)#10H@"4!I9B!T97-T("(D
M*%!(4"DB(#T@(FYO([EMAIL PROTECTED]&AE;B!<"B )96-H;R B5T%23DE.1SH@<F5C<F5A
F=&EN9R!T:&[EMAIL PROTECTED];VX@:6YD97@@;F5E9',@<&AP(B [7 H`
`
end
