Hannes Magnusson skrev:
On Thu, Jan 8, 2009 at 09:03, Nilgün Belma Bugüner
r,

Index: xhtml.php
===================================================================
RCS file: /repository/phd/formats/xhtml.php,v
retrieving revision 1.84
diff -u -r1.84 xhtml.php
--- xhtml.php   3 Jan 2009 12:55:22 -0000       1.84
+++ xhtml.php   8 Jan 2009 07:58:11 -0000
@@ -802,11 +802,11 @@
    public function format_methodparam_parameter($open, $name, $attrs) {
        if ($open) {
            if (isset($attrs[PhDReader::XMLNS_DOCBOOK]["role"])) {
-                return ' <tt class="parameter reference">&amp;$';
+                return ' <i><tt class="parameter reference">&amp;$';
            }
-            return ' <tt class="parameter">$';
+            return ' <i><tt class="parameter">$';
        }
-        return "</tt>";
+        return "</tt></i>";

Lars would slap you with his semantic wand if this gets committed.

The CSS changes earlier in this thread are fine with me if someone
wants to commit.

-Hannes

Indeed. That i-element serves only a presentational cause and therefore should be handled by CSS.

A good rule of thumb when it comes to (X)HTML is to be very reluctant about adding tags or attributes, and very eager to strip them out.


Lars Gunther

Reply via email to