On Sun, Apr 5, 2009 at 08:56, Keito Uchiyama <ke...@hcs.harvard.edu> wrote: > Philip Olson wrote: >> >> Nice! :) But please post the patch as an attachment or a link online as it >> gets altered in email. And if you're planning on documenting more then a CVS >> account is appropriate: >> >> - http://php.net/cvs-php >> >> As for the markup, the only problems I see are whitespace issues because >> for XML it should be one space indention. It may seem strict but overall it >> makes for clean source files. And wrapping should be around 72 characters >> but that number is flexible. > > Hi Philip, > > Thanks! :) I've posted an updated version of the patch at > <http://www.hcs.harvard.edu/~keito/ncurses2.patch>.
Awesome work. One thing I would update: + Returns 0 on success, -1 if the color table could not be allocated (and all similar), use <literal>0</literal>, <literalt>-1</literal>.. it makes it more clear that these are actual return values. -Hannes
