On Wed, May 26, 2010 at 15:32, Richard Quadling <rquadl...@googlemail.com> wrote: > On 25 May 2010 19:37, Hannes Magnusson <hannes.magnus...@gmail.com> wrote: >> On Tue, May 25, 2010 at 13:08, Richard Quadling >> <rquadl...@googlemail.com> wrote: >>> On 24 May 2010 16:00, Hannes Magnusson <hannes.magnus...@gmail.com> wrote: >>>> On Mon, May 24, 2010 at 03:25, Philip Olson <phi...@roshambo.org> wrote: >>>>> >>> At this stage, I'm wondering why we don't simply collect all the errors ... >>> >>> <?php libxml_use_internal_errors(true); ?> >> >> I thought we did? Unless --enable-xml-details was set > > Then how are the warnings being displayed on the online editor from > the xinclude() call? > > And then the penny drops. > > The editor is using --disable-segfault-error to NOT capture the > errors. > http://svn.php.net/viewvc/web/doc-editor/trunk/php/conf/project.php.ini?view=markup#l25 > > > So, if we are not interested in xinclude errors, captured by > libxml_use_internal_errors(true) or otherwise, then a simple > > @$dom->xinclude(); > libxml_clear_errors();
@ is never the solution. Fix print_xml_errors() to discard the error and call it after ->xinclude(). And remove --disable-segfault-error frrom the OE --disable-segfault-error should *NOT* be enabled by default. It is the last resort to workaround a bug in libxml2 and should only be used when stuff breaks that badly. -Hannes
