[ 
https://issues.apache.org/jira/browse/PIG-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842783#action_12842783
 ] 

Pradeep Kamath commented on PIG-1205:
-------------------------------------

New patch looks good - i had one question - cleanupOnFailure() is implemented 
as an empty body method - wondering if there should be some cleanup of the 
hbase data which was written out since this method is called when the job 
fails? If so, please add the the clean up code in that method. 

If the above comment and the extra javac warning reported by Hadoop QA in the 
previous comment are address, the patch is good to be committed (again, if 
someone else who has hbase knowledge can review the hbase portion that would be 
good, since I have not reviewed that part).

> Enhance HBaseStorage-- Make it support loading row key and implement StoreFunc
> ------------------------------------------------------------------------------
>
>                 Key: PIG-1205
>                 URL: https://issues.apache.org/jira/browse/PIG-1205
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: 0.7.0
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>             Fix For: 0.7.0
>
>         Attachments: PIG_1205.patch, PIG_1205_2.patch, PIG_1205_3.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to