[ 
https://issues.apache.org/jira/browse/PIG-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842806#action_12842806
 ] 

Dmitriy V. Ryaboy commented on PIG-1205:
----------------------------------------

Jeff, thanks for all your work on this!
It occurs to me that the constructor with position-dependent arguments is not a 
scalable pattern. We may have many options we might want to set for Hbase in 
the future (only load certain column-families, minimum record date, interpret 
stored data as strings or bytes, etc), and having to set them by adding on a 
third, fourth, fifth argument to the constructor is not really great.

We could instead use commons-cli (already used by Hadoop, so no new 
dependencies) or args4j to parse a command-line style argument. So invocation 
would look like this instead:

load 'hdfs://blah" using HBaseStorage("-columns=col1,col2 -loadRowKey=true 
-castUsing=Utf8StorageConverter")

What do you think? 

> Enhance HBaseStorage-- Make it support loading row key and implement StoreFunc
> ------------------------------------------------------------------------------
>
>                 Key: PIG-1205
>                 URL: https://issues.apache.org/jira/browse/PIG-1205
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: 0.7.0
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>             Fix For: 0.7.0
>
>         Attachments: PIG_1205.patch, PIG_1205_2.patch, PIG_1205_3.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to