[
https://issues.apache.org/jira/browse/PIG-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856992#action_12856992
]
Ashutosh Chauhan commented on PIG-1363:
---------------------------------------
Hudson is flaky (again). Result of test-patch:
{noformat}
[exec]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
{noformat}
Patch is ready for review.
> Unnecessary loadFunc instantiations
> -----------------------------------
>
> Key: PIG-1363
> URL: https://issues.apache.org/jira/browse/PIG-1363
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: pig-1363.patch
>
>
> In MRCompiler loadfuncs are instantiated at multiple locations in different
> visit methods. This is inconsistent and confusing. LoadFunc should be
> instantiated at only one place, ideally in LogToPhyTanslation#visit(LOLoad).
> A getter should be added to POLoad to retrieve this instantiated loadFunc
> wherever it is needed in later stages of compilation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
