[
https://issues.apache.org/jira/browse/PIG-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857590#action_12857590
]
Hadoop QA commented on PIG-1363:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12441862/pig-1363_1.patch
against trunk revision 934488.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/298/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/298/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/298/console
This message is automatically generated.
> Unnecessary loadFunc instantiations
> -----------------------------------
>
> Key: PIG-1363
> URL: https://issues.apache.org/jira/browse/PIG-1363
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: pig-1363.patch, pig-1363_1.patch
>
>
> In MRCompiler loadfuncs are instantiated at multiple locations in different
> visit methods. This is inconsistent and confusing. LoadFunc should be
> instantiated at only one place, ideally in LogToPhyTanslation#visit(LOLoad).
> A getter should be added to POLoad to retrieve this instantiated loadFunc
> wherever it is needed in later stages of compilation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
