[
https://issues.apache.org/jira/browse/PIG-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869422#action_12869422
]
Alan Gates commented on PIG-1420:
---------------------------------
Output of ant test-patch
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 6 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] -1 release audit. The applied patch generated 528 release
audit warnings (more than the trunk's current 527 warnings).
[exec]
[exec]
[exec]
{code}
The output of the release audit warning is:
{code}
262d261
< [java] !?????
/home/gates/src/pig/PIG-1420/trunk/build/pig-0.8.0-dev/docs/jdiff/changes/org.apache.pig.data.DataByteArray.html
{code}
I think this can be safely ignored, so we're good.
I'll pass the hat here to get donations to buy Dmitriy a linux box so he can
have more than one version of Java. :)
> Make CONCAT act on all fields of a tuple, instead of just the first two
> fields of a tuple
> -----------------------------------------------------------------------------------------
>
> Key: PIG-1420
> URL: https://issues.apache.org/jira/browse/PIG-1420
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Russell Jurney
> Assignee: Russell Jurney
> Fix For: 0.7.0
>
> Attachments: addconcat2.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> org.apache.pig.builtin.CONCAT (which acts on DataByteArray's internally) and
> org.apache.pig.builtin.StringConcat (which acts on Strings internally), both
> act on the first two fields of a tuple. This results in ugly nested CONCAT
> calls like:
> CONCAT(CONCAT(A, ' '), B)
> The more desirable form is:
> CONCAT(A, ' ', B)
> This change will be backwards compatible, provided that no one was relying on
> the fact that CONCAT ignores fields after the first two in a tuple. This
> seems a reasonable assumption to make, or at least a small break in
> compatibility for a sizable improvement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
