On 19 November 2012 13:26, Eric Anholt <e...@anholt.net> wrote: > Paul Berry <stereotype...@gmail.com> writes: > > > From: Ian Romanick <ian.d.roman...@intel.com> > > > > To use multithreading with xlib, you're supposed to call XInitThreads > > before any other xlib call. Without this, xlib and GLX calls won't be > > thread safe. It looks like this test had an extra mutex to work > > around the lack of thread saftey in glXCreateContext and > > glXMakeCurrent. > > I don't think that was the intent behind the mutexes -- really just > wanted the two rendering threads to be totally serialized. If we wanted > to test threads doing simultaneous drawing, we would probably want to do > drawing in a loop and hopefully get the two threads started at the same > time. > > That said, we should definitely use XInitThreads(). >
Ok, I'll change the patch to just do XInitThreads().
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
