On Friday, November 07, 2014 01:10:49 PM Tapani wrote: > On 11/07/2014 12:40 AM, Ian Romanick wrote: > > The test looks fine enough, but could you add a spec quotation to defend it? > > ok, I'll send v2 of this together with few other tests > > > On 11/04/2014 04:19 AM, Tapani Pälli wrote: > >> Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> > >> --- > >> tests/spec/glsl-es-3.00/compiler/invariant_all.frag | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> create mode 100644 tests/spec/glsl-es-3.00/compiler/invariant_all.frag > >> > >> diff --git a/tests/spec/glsl-es-3.00/compiler/invariant_all.frag > >> b/tests/spec/glsl-es-3.00/compiler/invariant_all.frag > >> new file mode 100644 > >> index 0000000..37031cf > >> --- /dev/null > >> +++ b/tests/spec/glsl-es-3.00/compiler/invariant_all.frag > >> @@ -0,0 +1,12 @@ > >> +#version 300 es > > The #version shouldn't be necessary with the current infrastructure, right? > > I put it there as the other tests had it. Also GLSL ES 1.00 does not > have such error so this is specific to the version.
Could you put it after the comment block as it is in the existing tests?
I think that will make it clearer
>
> >> +// [config]
> >> +// expect_result: fail
> >> +// glsl_version: 3.00
> >> +// [end config]
> >> +//
> >> +// Check that 'invariant(all)' cannot be used in fragment shader
> >> +
> >> +#pragma STDGL invariant(all)
> >> +void main()
> >> +{
> >> +}
> >>
>
> _______________________________________________
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
