Please post a plan for what you're doing before you do all the work to make sure you don't do anything unnecessary.

Like I said before, most of the glsl1 tests should already be covered by existing shader runner tests. There's probably not too many that need to be ported.

-Brian

On 10/10/2015 12:43 PM, Juliet Fru wrote:
Hi,

Alright, I  will make these changes and send in the patch.

Thanks,
Juliet

On Thu, Oct 8, 2015 at 3:31 AM, Matt Turner <matts...@gmail.com
<mailto:matts...@gmail.com>> wrote:

    On Wed, Oct 7, 2015 at 1:48 AM, Juliet Fru <juliet...@gmail.com
    <mailto:juliet...@gmail.com>> wrote:
    > This test replaces the original tglsl1.cpp test
    > ---
    >  tests/all.py                        |    1 +
    >  tests/spec/gl-1.0/CMakeLists.gl.txt |    1 +
    >  tests/spec/gl-1.0/shading-lang.c    | 1939 
+++++++++++++++++++++++++++++++++++
    >  3 files changed, 1941 insertions(+)
    >  create mode 100644 tests/spec/gl-1.0/shading-lang.c

    I don't like this at all. These tests should become shader_test files
    -- not just a straight port from glean to the piglit framework.




_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit


_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to