On 13 December 2017 at 12:54, Tapani Pälli <tapani.pa...@intel.com> wrote:
>> The test doesn't care how well eglCopyBuffers itself works - aim it to >> illustrate the buggy validation in Mesa. >> Hence the wait + pixmap readback are not really needed. >> >> Admittedly the test name is quite misleading as-is - I'm short on >> alternatives though :-( > > > OK, yeah that is fine. It's not far from 'complete test' though but such > athing can be also added later. > Agreed. Would you have any additional suggestions on this patch? Input on the nitpicks (originally put by yours truly) would be appreciated: - suggestions for test name and category? - should we bother at all with piglit_egl_get_default_display(EGL_NONE) - yay X11+DRI3 crashes somewhere in the xshmfence code... DRI2 works fine. Thanks Emil _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit