Am 19.01.2018 um 06:35 schrieb Eric Anholt: > Brian Paul <bri...@vmware.com> writes: > >> On 01/18/2018 01:27 PM, Eric Anholt wrote: >>> Brian Paul <bri...@vmware.com> writes: >>> >>>> To avoid an infinite loop. See code comments for details. >>> >>> Skipping a failing test and returning pass is wrong to me. >> >> It's not ideal. But the bug is in LLVM and cannot readily be fixed in >> llvmpipe. >> >> I could have the test return a WARN result in this situation. Would >> that be better? > > It's still a bug in the driver, even if it's because the driver's using > a buggy external library. It should be a fail. >
Albeit it's just a guess it will hang. With a fixed llvm 3.8 from the stable branch, it would not hang and pass. Or IIRC if you don't have a avx-capable cpu, it also would not hang (and with a non-x86 cpu it won't hang neither). But I don't really care either way if it just reports fail in this case. (Would be nice if we could just determine the hang empirically I suppose, if the testcase runs for more than a second kill it and it's a fail, but that doesn't work easily.) Roland _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit