I think the bad enum is some copy and paste from an above test case. I feel it should be changed as well, right now the test is relying on the level / size being validated before the format.
- Anthony P.S. Sorry for the spam on these changes, I had a problem with my filters and thought the changes weren't being sent, but well... they were. On Wed, Mar 28, 2018 at 11:41 AM, Arthur Huillet <arthur.huil...@free.fr> wrote: > I'm confused why the test is passing a bad enum when its purpose seems to > be to test a non-existent level. > In any case, your change looks correct to me. > > Reviewed-by: Arthur Huillet <ahuil...@nvidia.com> > > > On 28.03.2018 17:15, Anthony Pesch wrote: > >> From: Anthony Pesch <ape...@nvidia.com> >> >> Change expected error from INVALID_OPERATION to INVALID_VALUE when >> querying >> a level which hasn't been explicitly defined. This is a valid operation, >> the >> error set should be due to the requested width and height being greater >> than >> the default width and height of zero. >> --- >> tests/spec/arb_get_texture_sub_image/errors.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/spec/arb_get_texture_sub_image/errors.c >> b/tests/spec/arb_get_texture_sub_image/errors.c >> index 34fec4a95..57875fa6a 100644 >> --- a/tests/spec/arb_get_texture_sub_image/errors.c >> +++ b/tests/spec/arb_get_texture_sub_image/errors.c >> @@ -200,7 +200,7 @@ test_invalid_values(void) >> 8, 8, 1, /* size */ >> GL_RGBA, GL_FLOAT, /* bad enum */ >> sizeof(buffer), buffer); >> - if (!piglit_check_gl_error(GL_INVALID_OPERATION)) >> + if (!piglit_check_gl_error(GL_INVALID_VALUE)) >> pass = false; >> >> /* Test getting invalid offset */ >> > > -- > A. Huillet >
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
