>- DigestAuthentication in not possible in a pre-emptive way (like
>Basic Authentication), because needs some data from the first
>response

I haven't looked at it in a while, but I believe my assumption was that the 
DigestAuthentication class would perform this initial request internally. Is 
there any reason you couldn't do it that way?

>- i added a method
>    public abstract String getMethod();
>  and put the implementation in any subclass ... this is required for
>the DigestAuthentication (by RFC), and could help also in other cases

Why not have it return a Query.Method?

>- i added a public int getStatus() method and moved the related
>variable out of the method, could help ... and maybe also a
>getMessage() with the returned message could be useful, at least to
>have more info when needed

Makes sense.

>Ah, one last thing, some little parts of the code are derived from one
>class in Tomcat and one class in HttpClient, i have put these
>references in the initial comment of the source, is this enough ?

I think we'll also need to add this to the NOTICE file. Thanks for the heads-up.

>For tests, now it's working with Apache 2.x and mod_digest , if
>someone is interested (at least to try) i could send some info to
>setup the stuff. Next tests are on Tomcat. But all this Server-side
>stuff is not included in sources, is it ok ?

I think it would be good to include it, if we can.

Reply via email to