Hi to all, first, thanks for your feedback ... One quick question before: the ByteArraySerializer (and maybe the patch for BinarySerializer) are already working ... they could go into 1.2 release, ok ? I've never tried to commit on Pivot trunk is it time for me to try ?
On the (not) usage of HttpClient, the reason was to not depend on it, and because Pivot Query would require some work to adapt ... On the adapter for HttpClient I like the idea, but think this would need more work, as Greg said. So my proposal is to start using the first implementation (in a few days i should release updated/new sources), and then see, ok ? > I haven't looked at it in a while, but I believe my assumption was that the > DigestAuthentication class would perform this initial request internally. Is > there any reason you couldn't do it that way? Interesting idea, I'll try ... >>- i added a method >> public abstract String getMethod(); >> and put the implementation in any subclass ... this is required for >>the DigestAuthentication (by RFC), and could help also in other cases > > Why not have it return a Query.Method? The RFC say that i have to encode the HTTP Method name, like "GET". >>- i added a public int getStatus() method and moved the related >>variable out of the method, could help ... and maybe also a >>getMessage() with the returned message could be useful, at least to >>have more info when needed > > Makes sense. OK, great. For changes to Query, how can i do: i put all modifications to my version of the file, send to the group sources (with TODO markers on all modifications), then someone do the merge with the trunk version ? Or should i synchronize with the latest version (i have that from one/two week ago) and send the full file ? If yes, i could do all this after Christopher modifications, because i need other days before to finish all this stuff. > I think we'll also need to add this to the NOTICE file. Thanks for the > heads-up. De nada. >>For tests, now it's working with Apache 2.x and mod_digest , if >>someone is interested (at least to try) i could send some info to >>setup the stuff. Next tests are on Tomcat. But all this Server-side >>stuff is not included in sources, is it ok ? > > I think it would be good to include it, if we can. Ok, but we should think at a simple packaging of these sources and readme (for example for apache I'm thinking on only write how to do, with all commands in the right sequence). Thanks, Sandro
