> > PIVOT-20: Complete collection classes > > I have completed the Pivot-native implementations of the list classes, but > HashMap and HashSet remain outstanding and are still just wrappers around > their JDK counterparts. Todd was originally assigned to this task, but if > anyone else is interested and has time, you are welcome to tackle it. We > imagine that the bulk of the work will be in HashMap, since HashSet can > internally use a map to maintain its own state. Alternatively, the > implementer may find it easier to share some common code via a package > private class. >
I remain unconvinced that doing a pivot-native implementation will buy you sufficient performance gain to warrant the extra maintenance burden. HashMap's and their related HashSet's are incredibly finicky devices, with lots of tradeoffs to make to achieve reasonable performance in odd corner cases. The cost of some indirection and the extra 16-odd bytes per object is hardly likely to be worth it, especially given hotspot's ability to inline method calls. Regards, Noel.
