[
https://issues.apache.org/jira/browse/PIVOT-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743074#action_12743074
]
Todd Volkert commented on PIVOT-198:
------------------------------------
After looking back at TreeView, I think that we should keep it as is. We have
to update the internal Path instances when we receive data events. For
instance, we decrement path indexes when a preceding path element is removed
from the list. As such, we can't use ImmutablePath instances internally the
way the code is currently structured. We could choose to use ImmutablePath
instances internally if we created new Paths instead of updating the existing
paths, but it's not clear (and is unlikely) that such a method would be more
efficient than the current method. I suggest renaming this ticket "Create
ImmutablePath class" and closing it.
> Create ImmutablePath class; update TreeView to use ImmutableList in
> getSelectedPaths()
> --------------------------------------------------------------------------------------
>
> Key: PIVOT-198
> URL: https://issues.apache.org/jira/browse/PIVOT-198
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 1.3
> Reporter: Greg Brown
> Assignee: Todd Volkert
> Priority: Minor
> Fix For: 1.3
>
>
> Create an ImmutablePath class that extends Path; use these internally in
> TreeView so we can return an ImmutableList wrapper around the selected paths
> and avoid the deep copy that we currently perform.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
