[ 
https://issues.apache.org/jira/browse/PIVOT-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743182#action_12743182
 ] 

Greg Brown commented on PIVOT-198:
----------------------------------

We have to do the same thing with Spans in ListView and TableView, since Spans 
are also immutable. That's the tradeoff I mentioned when I originally suggested 
this change. My guess is that the performance overhead of creating a new span 
or path vs. updating an existing one is negligible. So I still think it is 
worth doing. Also, this is even less of an issue for TreeView than ListView or 
TableView, since it is far less likely to have multiple nodes selected.



> Create ImmutablePath class; update TreeView to use ImmutableList in 
> getSelectedPaths()
> --------------------------------------------------------------------------------------
>
>                 Key: PIVOT-198
>                 URL: https://issues.apache.org/jira/browse/PIVOT-198
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>    Affects Versions: 1.3
>            Reporter: Greg Brown
>            Assignee: Todd Volkert
>            Priority: Minor
>             Fix For: 1.3
>
>
> Create an ImmutablePath class that extends Path; use these internally in 
> TreeView so we can return an ImmutableList wrapper around the selected paths 
> and avoid the deep copy that we currently perform.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to