[
https://issues.apache.org/jira/browse/PIVOT-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761177#action_12761177
]
Todd Volkert commented on PIVOT-132:
------------------------------------
You're always free to work on any ticket, but my 2c is that 1.4 tickets would
be better served. We use the source cache so infrequently in code that this is
not likely to hurt the application more than a few milliseconds. But then
again, maybe I'm wrong -- perhaps you could start by profiling our calls to the
resource cache to see how big a hit we're taking?
> pivot/wtk/ApplicationContext.java:1201
> pivot.wtk.ApplicationContext.resourceCache is or uses a map or set of URLs,
> which can be a performance hog
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIVOT-132
> URL: https://issues.apache.org/jira/browse/PIVOT-132
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 1.1, 1.2
> Reporter: Sandro Martini
> Assignee: Greg Brown
> Priority: Minor
> Fix For: 1.5
>
>
> As from the latest FindBugs, this warning (with High Priority) in hilited:
> pivot/wtk/ApplicationContext.java:1201
> pivot.wtk.ApplicationContext.resourceCache is or uses a map or set of URLs,
> which can be a performance hog
> And from their doc related to this:
> This method or field is or uses a Map or Set of URLs. Since both the equals
> and hashCode method of URL perform domain name resolution, this can result in
> a big performance hit.
> See
> http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html
> for more information.
> Consider using java.net.URI instead.
> Trying to change URL with URI is ok here, but given compilation error in
> approx. 24 classes related to this.
> Needs further study.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
