[
https://issues.apache.org/jira/browse/PIVOT-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766461#action_12766461
]
Sandro Martini commented on PIVOT-132:
--------------------------------------
Now the same problem happens on ImageView class, this is the detail:
ApplicationContext.java:1444
org.apache.pivot.wtk.ApplicationContext.resourceCache is or uses a map or set
of URLs, which can be a performance hog
ImageView.java:69 org.apache.pivot.wtk.ImageView.loadMap is or uses a map or
set of URLs, which can be a performance hog
Other the performance side of this (that probably for is is not a real
problem), I'll make some tests to ensure if this is really a bad practice.
> pivot/wtk/ApplicationContext.java:1201
> pivot.wtk.ApplicationContext.resourceCache is or uses a map or set of URLs,
> which can be a performance hog
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIVOT-132
> URL: https://issues.apache.org/jira/browse/PIVOT-132
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Affects Versions: 1.1, 1.2
> Reporter: Sandro Martini
> Assignee: Greg Brown
> Priority: Minor
> Fix For: 1.5
>
>
> As from the latest FindBugs, this warning (with High Priority) in hilited:
> pivot/wtk/ApplicationContext.java:1201
> pivot.wtk.ApplicationContext.resourceCache is or uses a map or set of URLs,
> which can be a performance hog
> And from their doc related to this:
> This method or field is or uses a Map or Set of URLs. Since both the equals
> and hashCode method of URL perform domain name resolution, this can result in
> a big performance hit.
> See
> http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html
> for more information.
> Consider using java.net.URI instead.
> Trying to change URL with URI is ok here, but given compilation error in
> approx. 24 classes related to this.
> Needs further study.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
