Thanks. I have some free time right now (at least until the next crisis at work erupts), so I'm picking off the simpler issues from the JIRA.
I thought Todd had checked in an eclipse-formatter file? I can't seem to find it in SVN right now. Cool, I'm happy to follow the pivot-style, although I disagree with the Pascal-style single-return-from-routine theory. I'm in the linux-kernel-style multiple-return early-exit camp :-) -- Noel. Greg Brown wrote: > Noel, > > Great work on your recent checkins - thanks! I just have a couple > minor coding style comments: > > - Don't include a space after a cast operator. > > - Do include spaces around mathematical operators (e.g. 1 + 2 vs. 1+2). > > - Try to structure your methods to use a single return statement, > rather than returning from arbitrary points in the method. It makes it > easier to follow the logic. > > Thanks! > Greg >
