Yeah, yeah - I know you think my methods are too long. ;-) But in this context, "long" means "anything more than 3 or 4 lines".

You may disagree, but I find that a single return value does improve readability.


On Nov 11, 2009, at 9:12 AM, Christopher Brind wrote:

You could argue that if your methods are that long, they are doing too much.
:)


2009/11/11 Greg Brown <[email protected]>

I thought Todd had checked in an eclipse-formatter file? I can't seem to
find it in SVN right now.


It was moved to the new /project branch Todd created (it used to be in a
/project sub-directory of /trunk):

http://svn.apache.org/repos/asf/incubator/pivot/project/pivot_style.xml

It is also in the Wiki:

http://cwiki.apache.org/confluence/display/PIVOT/Platform+Developer+Info


Cool, I'm happy to follow the pivot-style, although I disagree with the
Pascal-style single-return-from-routine theory.
I'm in the linux-kernel-style multiple-return early-exit camp :-)


Though I generally don't use the style myself, I do think multiple returns are OK for trivial methods. However, I think it has a negative effect on
readability for longer methods.



Reply via email to