Chris Wilson <ch...@chris-wilson.co.uk> writes: > + if (width == stride) { > + width *= height; > + height = 1; > + }
Do we need a check here that the mulitplication doesn't overflow? pixman_multiply_overflows_int() can be used for that. > + if (width == src_stride && width == dst_stride) { > + width *= height; > + height = 1; > + } Same here, and also braces go on their own line in pixman. It would also be useful to have a brief comment in the commit log about what a linear image is. Soren _______________________________________________ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman