On Fri, 06 May 2011 09:18:51 +0200, Soeren Sandmann <sandm...@cs.au.dk> wrote:
> Chris Wilson <ch...@chris-wilson.co.uk> writes:
> 
> > +    if (width == stride) {
> > +   width *= height;
> > +   height = 1;
> > +    }
> 
> Do we need a check here that the mulitplication doesn't overflow?
> pixman_multiply_overflows_int() can be used for that.

I think we are safe here, as we check for height*stride (in bytes)
overflow during create_bits().

I'll work these small patches into a real submission with a corresponding
addition to the test suite. Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Pixman mailing list
Pixman@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pixman

Reply via email to