Hi Shawn, These changes look good to me. The only catch I see is that you'll need to merge with the rename stuff that I just putback. That code has a few places where it returns HTTP errors for new functions I added. Those should be converted to the symbolic codes you're using throughout the rest of your wad.
Thanks for fixing this. -j On Sun, Feb 17, 2008 at 02:14:12AM -0600, Shawn Walker wrote: > The following webrev includes proposed fixes for the following bugs: > > 255 Symbolic HTTP response codes should be used > 518 Some pkgsend tests fail due to -s parameter being unspecified > > http://cr.opensolaris.org/~swalker/pkg-255-518/ > > This should be far better than the first attempt I posted a few days ago. > > In addition, I made a few more changes directly related to http > responses based on Danek's comments. > > Specifically, I have changed all code that used "from httplib import > X" to use "import httplib"; and I consolidated a status check in > publish.py. > > Contributor #OS0004 > > Cheers, > -- > Shawn Walker, Software and Systems Analyst > http://binarycrusader.blogspot.com/ > > "To err is human -- and to blame it on a computer is even more so." - > Robert Orben > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
