On Wed, Feb 20, 2008 at 12:54 PM, Stephen Hahn <[EMAIL PROTECTED]> wrote: > * Shawn Walker <[EMAIL PROTECTED]> [2008-02-20 18:12]: > > > > On Feb 20, 2008 11:55 AM, Stephen Hahn <[EMAIL PROTECTED]> wrote: > > > * Shawn Walker <[EMAIL PROTECTED]> [2008-02-20 05:21]: > > > > On Feb 19, 2008 2:41 PM, <[EMAIL PROTECTED]> wrote: > > > > > Hi Shawn, > > > > > These changes look good to me. The only catch I see is that you'll > need > > > > > to merge with the rename stuff that I just putback. That code has a > few > > > > > places where it returns HTTP errors for new functions I added. Those > > > > > should be converted to the symbolic codes you're using throughout the > > > > > rest of your wad. > > > > > > > > Per your request, I have merged the latest tip with my changes and did > > > > a quick run through the source again and then ran make test. > > > > > > > > hg bundle (hope I did this right): > > > > http://cr.opensolaris.org/~swalker/pkg-255-518/raw_files/pkg-255-518.hg > > > > > > > > Updated webrev (from after I did recommit): > > > > http://cr.opensolaris.org/~swalker/pkg-255-518/ > > > > > > If the bundle worries you, use hg export to send a patch as well. (I > > > find it easier to work with patches, personally. Maybe for enormous > > > changes a bundle would become more appropriate...) > > > > Alright, I'll just do this for each change then: > > > > 1) hg bundle > > > > 2) webrev > > > > 3) hg export > > > > That way it can be incorporated in whatever format works best. > > > > hg is relatively new to me so I'm having to re-learn the workflow. > > > > Is there a document somewhere that shows the expected set of steps > > once you're ready to commit something? > > I tend to live in the working copy, and usually do > > edit, test, nits, webrev, (await comments, make edits, retest), commit > with message, export/push > > If the push fails (or your patch applier comes back), then I use > rollback, pull -u, and start again. > > Your sequence is fine if you prefer to make intermediate commits to > track progress--then recommit will collapse them.
This is very helpful! Thanks. As a result of the above process, do you tend to keep a working copy for each set of changes you are doing? Cheers, -- Shawn Walker, Software and Systems Analyst http://binarycrusader.blogspot.com/ "To err is human -- and to blame it on a computer is even more so." - Robert Orben _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
