Hi Dan,

> Hi folks, here's a review (and for those waiting to try it, a proposed
> patch) for my rework of the cli testing.

>         http://cr.opensolaris.org/~dp/ips-tests/

In general, this looks good.  I just have a stupid question about the
depotcontroller:

depotcontroller.py:114 - Do we want to catch and return false for every
conceivable exception that this code might encounter?  Are there any
situations here where this should do more than return false?  I.e. print
an error, pass an excepiton upwards, etc?

Thanks,

-j

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to