On Tue 19 Feb 2008 at 12:48PM, [EMAIL PROTECTED] wrote:
> Hi Dan,
>
> > Hi folks, here's a review (and for those waiting to try it, a proposed
> > patch) for my rework of the cli testing.
>
> > http://cr.opensolaris.org/~dp/ips-tests/
>
> In general, this looks good. I just have a stupid question about the
> depotcontroller:
>
> depotcontroller.py:114 - Do we want to catch and return false for every
> conceivable exception that this code might encounter? Are there any
> situations here where this should do more than return false? I.e. print
> an error, pass an excepiton upwards, etc?
I couldn't think of one: We're doing an aliveness test on the depot.
Seems to me that: "I couldn't tell if the depot was alive or not" and
"the depot is not alive" are, in this case, basically the same thing...
I'll add a comment.
Thanks for looking it over,
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
