I did a quick pylint run late last night, and just looked at the
"E" output ("Errors") Here is the list. There look to be some
legit bugs in here. Please take a look.
n.b. I used the "pylintrc" file checked in by the portability project,
but I'm seeing some errors related to "pkg.portable". Not sure why.
-dp
************* Module modules.cpiofile
E1101: 89:_LowLevelFile.__init__: Module 'os' has no 'O_BINARY' member
E0602:165:_Stream._init_write_gz: Undefined variable 'NUL'
E0602:228:_Stream._init_read_gz: Undefined variable 'NUL'
E0602:233:_Stream._init_read_gz: Undefined variable 'NUL'
E0602:697:CpioFile.gzopen: Undefined variable 'tarname'
************* Module modules.fmri
E1101:155:PkgFmri.get_timestamp: Instance of 'Version' has no 'get_timestamp'
member
************* Module modules.subprocess_method
E0602:334:test: Undefined variable 'time'
************* Module modules.sysvpkg
E0602:200:SolarisPackage.makePkgVersion: Undefined variable 'PkgVersion'
************* Module modules.updatelog
E0602:346:UpdateLog._recv_updates: Undefined variable 'errno'
************* Module modules.version
E0602:111:DotSequence.is_same_minor: Undefined variable 'is_same_major'
************* Module modules.actions.directory
E1101: 73:DirectoryAction.install: Module 'pkg.portable' has no 'is_admin'
member
E1101: 99:DirectoryAction.install: Module 'pkg.portable' has no 'chown' member
************* Module modules.actions.driver
E0602:582:DriverAction.remove: Undefined variable 'image'
************* Module modules.actions.file
E1101:127:FileAction.install: Module 'pkg.portable' has no 'chown' member
E1101:135:FileAction.install: Module 'pkg.portable' has no 'rename' member
E1101:138:FileAction.install: Module 'pkg.portable' has no 'rename' member
************* Module modules.actions.generic
E1101:215:Action.__str__: Instance of 'Action' has no 'hash' member
E1101:274:Action.different: Instance of 'Action' has no 'hash' member
E1101:314:Action.generate_indices: Instance of 'Action' has no
'reverse_indices' member
E1101:318:Action.generate_indices: Instance of 'Action' has no 'hash' member
E1101:350:Action.makedirs: Module 'pkg.portable' has no 'split_path' member
E1101:355:Action.makedirs: Module 'pkg.portable' has no 'get_root' member
E1101:377:Action.makedirs: Module 'pkg.portable' has no 'chown' member
E1101:390:Action.makedirs: Module 'pkg.portable' has no 'chown' member
E1101:403:Action.makedirs: Module 'pkg.portable' has no 'chown' member
************* Module modules.actions.license
E1101: 90:LicenseAction.install: Module 'pkg.portable' has no 'chown' member
************* Module modules.bundle.SolarisPackageDatastreamBundle
E0602:109:SolarisPackageDatastreamBundle.action: Undefined variable 'unknown'
E1101:112:SolarisPackageDatastreamBundle.action: Class 'file' has no
'FileAction' member
E0602:116:SolarisPackageDatastreamBundle.action: Undefined variable 'directory'
E0602:120:SolarisPackageDatastreamBundle.action: Undefined variable 'link'
E0602:123:SolarisPackageDatastreamBundle.action: Undefined variable 'hardlink'
E0602:126:SolarisPackageDatastreamBundle.action: Undefined variable 'unknown'
************* Module modules.bundle.SolarisPackageDirBundle
E1101: 89:SolarisPackageDirBundle.action: Class 'file' has no 'FileAction'
member
E0602: 93:SolarisPackageDirBundle.action: Undefined variable 'directory'
E0602: 97:SolarisPackageDirBundle.action: Undefined variable 'link'
E0602:100:SolarisPackageDirBundle.action: Undefined variable 'hardlink'
E1101:103:SolarisPackageDirBundle.action: Instance of '_Printer' has no
'LicenseAction' member
E0602:107:SolarisPackageDirBundle.action: Undefined variable 'unknown'
************* Module modules.bundle.TarBundle
E1101: 51:TarBundle.action: Class 'file' has no 'FileAction' member
E0602: 56:TarBundle.action: Undefined variable 'directory'
************* Module modules.client.filelist
E1101:203:FileList.get_files: Module 'pkg.portable' has no 'link' member
************* Module modules.client.image
E0602:565:Image.installed_file_authority: Undefined variable 'fmri'
E1101:970:Image.get_user_by_name: Module 'pkg.portable' has no
'get_user_by_name' member
E1101:975:Image.get_name_by_uid: Module 'pkg.portable' has no 'get_name_by_uid'
member
E1101:979:Image.get_group_by_name: Module 'pkg.portable' has no
'get_group_by_name' member
E1101:983:Image.get_name_by_gid: Module 'pkg.portable' has no 'get_name_by_gid'
member
************* Module modules.portable.os_darwin
E0102: 34:copyfile: function already defined line 31
************* Module modules.portable.os_sunos
E0102: 35:get_isainfo: function already defined line 32
E0102: 38:get_release: function already defined line 32
E0102: 41:get_platform: function already defined line 32
************* Module modules.server.transaction
E1101:321:Transaction.publish_package: Module 'pkg.portable' has no 'rename'
member
E1101:335:Transaction.publish_package: Module 'pkg.portable' has no 'rename'
member
E1101:353:Transaction.publish_package: Module 'pkg.portable' has no 'rename'
member
************* Module publish
E1111:393: Assigning to function call which doesn't return
************* Module setup
External dependencies
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
