On Wed, Apr 09, 2008 at 10:56:47AM -0700, Dan Price wrote: > ************* Module modules.cpiofile > E1101: 89:_LowLevelFile.__init__: Module 'os' has no 'O_BINARY' member > E0602:165:_Stream._init_write_gz: Undefined variable 'NUL' > E0602:228:_Stream._init_read_gz: Undefined variable 'NUL' > E0602:233:_Stream._init_read_gz: Undefined variable 'NUL' > E0602:697:CpioFile.gzopen: Undefined variable 'tarname'
I'm just leaving the cpiofile ones alone for now. They're harmless, though I suppose I should fix them at some point. > ************* Module modules.fmri > E1101:155:PkgFmri.get_timestamp: Instance of 'Version' has no 'get_timestamp' > member Fixed. > ************* Module modules.subprocess_method > E0602:334:test: Undefined variable 'time' Fixed (along with the "timedanek" fix). > ************* Module modules.sysvpkg > E0602:200:SolarisPackage.makePkgVersion: Undefined variable 'PkgVersion' Fixed. > ************* Module modules.updatelog > E0602:346:UpdateLog._recv_updates: Undefined variable 'errno' Fixed. > ************* Module modules.version > E0602:111:DotSequence.is_same_minor: Undefined variable 'is_same_major' Fixed. > ************* Module modules.actions.driver > E0602:582:DriverAction.remove: Undefined variable 'image' Fixed. > ************* Module modules.actions.generic > E1101:215:Action.__str__: Instance of 'Action' has no 'hash' member > E1101:274:Action.different: Instance of 'Action' has no 'hash' member > E1101:314:Action.generate_indices: Instance of 'Action' has no > 'reverse_indices' member > E1101:318:Action.generate_indices: Instance of 'Action' has no 'hash' member These are all protected by hasattr() checks. I dunno if they'd go away if inside try/except. > ************* Module modules.bundle.SolarisPackageDatastreamBundle > E0602:109:SolarisPackageDatastreamBundle.action: Undefined variable 'unknown' > E1101:112:SolarisPackageDatastreamBundle.action: Class 'file' has no > 'FileAction' member > E0602:116:SolarisPackageDatastreamBundle.action: Undefined variable > 'directory' > E0602:120:SolarisPackageDatastreamBundle.action: Undefined variable 'link' > E0602:123:SolarisPackageDatastreamBundle.action: Undefined variable 'hardlink' > E0602:126:SolarisPackageDatastreamBundle.action: Undefined variable 'unknown' All these (and those in the other bundle classes) are because they do "from pkg.actions import *", and pylint doesn't seem to pick up on what names that introduces. I'm not sure what to do about that. > ************* Module modules.client.image > E0602:565:Image.installed_file_authority: Undefined variable 'fmri' Fixed. > ************* Module publish > E1111:393: Assigning to function call which doesn't return Fixed. I'll roll all these up into one bug and put up a webrev shortly. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
