On Tue 29 Apr 2008 at 04:43PM, Brock Pytlik wrote:
> When you have a chance please take a look at
> http://cr.opensolaris.org/~bpytlik/ips-fix-1338/
>
>
> It adds test cases for bug 1338 and also changes the error message
> reported to the user to something hopefully more useful.
Brock,
In general, this looks good. Thanks for starting with the test
case. The test cases look great, very thorough!
imageplan.py:
A few nits:
342 -- omit the ';'-- this habit takes about a month to break when you
are new to python :)
350 -- you might wish to file a bug for this issue; in general we try
to avoid comments like this (it simply invites the question:
why didn't you do the refactoring?), and instead look to the
bug database for this sort of recording.
355 -- can you provide some sample output? It's a bit hard to work
out what message this will actually emit.
359 -- this wants to be reformatted:
raise RuntimeError("No packages were installed because "
"package dependencies could not be satisfied\n" +
outstring)
That is to say, our convention is to do 4-space indent
on continuation lines without respect to parens or argument
boundaries.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
