Brock Pytlik wrote:
> When you have a chance please take a look at
> http://cr.opensolaris.org/~bpytlik/ips-fix-1338/
>
>
> It adds test cases for bug 1338 and also changes the error message
> reported to the user to something hopefully more useful.
>
Looks good.. I see that error is superfluous:
: [EMAIL PROTECTED]; python
Python 2.4.4 (#1, Feb 25 2008, 04:14:47) [C] on sunos5
Type "help", "copyright", "credits" or "license" for more information.
>>> a = ""
>>> if a:
... print "a"
... else:
... print "not a"
...
not a
>>>
so you can just do the same test w/ outstring as w/ error.
You may wish to consider your wording:
351 + outstring += "Installing %s
causes:\n\t%s\n" % \
352 + (f.get_name(), e)
as there was no attempt to install; perhaps "Cannot install" would be
better?
Thanks for adding the test case - we don't have enough of those.
- Bart
--
Bart Smaalders Solaris Kernel Performance
[EMAIL PROTECTED] http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
