On Wed, Apr 30, 2008 at 1:42 AM, Dan Price <[EMAIL PROTECTED]> wrote: > On Tue 29 Apr 2008 at 11:22PM, Danek Duvall wrote: > > On Tue, Apr 29, 2008 at 09:30:58PM -0700, Dan Price wrote: > > > > > http://cr.opensolaris.org/~dp/ips-twodepot/ > > > > You forgot to hg add t_twodepot.py? > > Indeed-- fixed, webrev updated.
First, I love the module name. Thankfully, reading the TwoDepot takes far less time than reading the "Two Towers" :-) http://cr.opensolaris.org/~dp/ips-twodepot/src/tests/Makefile.wdiff.html ========== Your friendly copyright minder ( :-) ) reminds you to update the copyrights. Nit: 25 KSH=/usr/bin/ksh 26 PYTHON = /usr/bin/python Note the spacing difference (I know you didn't change this but...). http://cr.opensolaris.org/~dp/ips-twodepot/src/tests/cli/t_twodepot.py.html ========== Is there a need to test the various usage options here as well in the two depot case? (-nvq, -nrvq, etc.) 438 + # We pick an arbitrary base port. This could be more 439 + # automated in the future. 440 + self.dcs[i] = self.start_depot(12000 + i, 441 + depotdir, depot_logfile) Looking to the future, is there any thought to check if the port is already bound or they have permission and automatically retry? No other comments at this time. Cheers, -- Shawn Walker "To err is human -- and to blame it on a computer is even more so." - Robert Orben _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
