On Wed 30 Apr 2008 at 11:05PM, Shawn Walker wrote: > First, I love the module name. Thankfully, reading the TwoDepot takes > far less time than reading the "Two Towers" :-) > > http://cr.opensolaris.org/~dp/ips-twodepot/src/tests/Makefile.wdiff.html > ========== > Your friendly copyright minder ( :-) ) reminds you to update the copyrights.
Thanks! > Nit: > > 25 KSH=/usr/bin/ksh > 26 PYTHON = /usr/bin/python > > Note the spacing difference (I know you didn't change this but...). I'll clean it up. > http://cr.opensolaris.org/~dp/ips-twodepot/src/tests/cli/t_twodepot.py.html > ========== > Is there a need to test the various usage options here as well in the > two depot case? (-nvq, -nrvq, etc.) I don't think so? None that I can think of are sensitive to being in a multiple-depots scenario. For now, I've done a fairly straightforward transcription of the existing twodepot test case-- we can certainly expand it later (and I think we should). > 438 + # We pick an arbitrary base port. > This could be more > 439 + # automated in the future. > 440 + self.dcs[i] = self.start_depot(12000 + i, > 441 + depotdir, depot_logfile) > > Looking to the future, is there any thought to check if the port is > already bound or they have permission and automatically retry? I had thought along those lines when writing the suite-- hence the comment. Thanks for reviewing this! -dp -- Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
