On Sat 10 May 2008 at 11:51PM, Shawn Walker wrote:
> The following webrev includes proposed fixes for the following bugs:
>
> 1876 operations on in-flight transactions will fail after depot restart
>
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-1876/
Shawn,
This looks great-- your work on the test case is very nice, and
should really give us added confidence about the depot. One question:
other than the addition of restart_depots(), are there any other
substantive changes in testutils.py? I wasn't sure, with all of the
whitespace changes.
One thing you might want to consider, is whether this test case
really belongs instead with depot tests (t_depot.py?) -- since really
this is a test of depot functionality. The summary for the test case
could also be slightly clearer, I think. Perhaps something like:
""" Send the depot a package an action at a time, restarting it
after each action sent, to ensure transactions work across
depot restart. Then do some basic operations using the package."""
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
