On Sun, May 11, 2008 at 12:31 AM, Dan Price <[EMAIL PROTECTED]> wrote: > On Sat 10 May 2008 at 11:51PM, Shawn Walker wrote: >> The following webrev includes proposed fixes for the following bugs: >> >> 1876 operations on in-flight transactions will fail after depot restart >> >> webrev: >> http://cr.opensolaris.org/~swalker/pkg-1876/ > > Shawn, > > This looks great-- your work on the test case is very nice, and > should really give us added confidence about the depot. One question: > other than the addition of restart_depots(), are there any other > substantive changes in testutils.py? I wasn't sure, with all of the > whitespace changes.
No. It's clear if you look at the udiffs instead of the wdiffs. That's just from me doing a "retab" so tabs get converted to spaces. > One thing you might want to consider, is whether this test case > really belongs instead with depot tests (t_depot.py?) -- since really > this is a test of depot functionality. The summary for the test case > could also be slightly clearer, I think. Perhaps something like: Sure. I don't have my heart set on a particular place. > """ Send the depot a package an action at a time, restarting it > after each action sent, to ensure transactions work across > depot restart. Then do some basic operations using the package.""" Yes, that's fine. I tend to be confusingly verbose sometimes :-) New webrev posted: http://cr.opensolaris.org/~swalker/pkg-1876-2/ Cheers, -- Shawn Walker "To err is human -- and to blame it on a computer is even more so." - Robert Orben _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
