This change seems okay to me.

-j

On Fri, May 09, 2008 at 02:33:26PM -0500, Tom Mueller (pkg-discuss) wrote:
> Danek,
> 
> Can you please review changes for the following issues:
> 
> 941 pkg install fails due to excessive length of filesystem path
> 1068 cleanup pylint errors caused by portable package
> 1231 make setup.py handle setting of VERSION in pkg/__init__.py
> 1425 Man pages are missing from the Windows build
> 1454 during pkg remove, lost+found folder contains invalid characters on 
> Windows (causes traceback)
> 
> The webrev is here: http://cr.opensolaris.org/~tmueller/portfixes1/
> 
> A review request was submitted for 941 earlier, but I've remerged the 
> changes with the latest code so I created a new webrev, along with these 
> other changes.
> 
> With the 941 change, downloaded files are no longer removed at all by 
> the action itself.  Instead, the global cleanup of the download 
> directory takes care of those files now.
> 
> For the 1454 change, I made the time format in the lost+found directory 
> match that of the timestamp in a package FMRI.
> 
> Thanks.
> Tom
> 
> 
> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to