Danek,
Please see inline.
Danek Duvall wrote:
I'm not okay with the fix to 941; one of the good things about using the
hash is that it's deterministic, while mkstemp() isn't. I do like the
removal of file_cleanup(), but I don't think this change is appropriate.
One of the things Bart's working on at the moment is changing how the files
are downloaded, and I'm sure he has some ideas on what the download area
needs to look like. I imagine we could get away without using the
pathname, and using the hash alone, which would (I believe) fix your
problem. Please talk to him about this.
I replied in more depth on this in another message. The hash value is
used to store the file under the download/<pid> directory. The
temporary file is only used when uncompressing the gzip'd file before
replacing or installing the target file. There are no temporary file
names under the download area. Can you please elaborate on your
objections to this?
The fix to 1454 is fine, though you should get rid of the spaces at the
end of the line while you're there.
Done.
As best I can tell, the changes to setup.py are fine, though I wonder
whether the print statement in build_py_func() is just for debugging?
I put this in so that we could see what version was used in the build
output.
1068 looks fine. I don't like having to explicitly list everything, and
would rather have some way of decorating the methods so that lint would
shut up, but this is fine for now.
Agreed. I didn't like explicitly listing everything either.
Thanks.
I'll wait until you are back to get this pushed.
Tom
I might experiment with going back to using classes to get your
inheritance, but once you've loaded the module with the class, extract all
its methods into the module namespace.
Since I'm out next week, you'll need to lobby someone else to shepherd your
changes in, though I can do it once I get back if no one else has done so.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center/OpenInstaller Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
