2008/5/11 Shawn Walker <[EMAIL PROTECTED]>:
> The following webrev includes proposed fixes for the following bugs:
>
> 1854 rework depot to use higher-level framework
> 1154 pkg.depotd tracebacks when given bad options
> 1237 pkg.depotd -p 80 -p 90 should return usage, but second option is
> taken
> 1887 depot status page output is not valid HTML
> 1888 memleaks test overwrites PYTHONPATH
Newly added:
1956 depotd performance hampered by unnecessary getpwuid/getgrgid calls
I believe I have now resolved the previous heap size issues with
streaming large files.
I had the opportunity this evening to discuss the streaming issue with
one of the lead cherrypy developers. Initially, he also suggested
using wsgi middleware just as the other person had. However, after
further discussion, he came up with an alternate solution that works
by subclassing and overriding CherryPy's response class object. This
solution allows us to write directly to the client (as we wanted all
along) just as we hada previously with BaseHTTPServer request.rfile.
After performing a "pkg install ss-dev" into an empty user image, pmap
reported this:
...
08061000 5360K rwx-- [ heap ]
...
total 14904K
Repeats of the above oepration never increased the heap size more than
40KiB; there were also times it did not increase at all. Please verify
this when reviewing.
webrev:
http://cr.opensolaris.org/~swalker/pkg-depot-6/
HG: changed src/Makefile
HG: changed src/depot.py
HG: changed src/modules/server/__init__.py
HG: changed src/modules/server/depot.py
HG: changed src/modules/server/repository.py
Notes:
* tarball I added *last* time:
src/pkgdefs/SUNWpython-cherrypy/CherryPy-3.0.3.tar.gz
* You must start the depot with an explicit port number argument (e.g.
-p 10000) otherwise it will try to connect to port 80
Cheers,
--
Shawn Walker
"To err is human -- and to blame it on a computer is even more so." -
Robert Orben
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
