2008/5/22 <[EMAIL PROTECTED]>: > Hi Shawn, > >> To make it easier to see the changes since the last webrev, I have >> created a special diff: >> http://cr.opensolaris.org/~swalker/pkg-depot-7/raw_files/pkg-depot-7.patch >> >> New webrev: >> http://cr.opensolaris.org/~swalker/pkg-depot-7/ > > I took a look at both of these. I think this looks good. I can't think > of anything else that I think you need to do.
Tom mentioned changing setup.py to do what I have the Makefile doing now for CherryPy. I'll try do to that tonight. Also, I won't be doing a putuback on this until Danek has had a chance to review it, at his request. > Out of curiosity, how did you find the corner case that necessitated the > addition of the on_end_request hook? I've been accused of purposefully trying to break programs by many people over the years :-) Actually, it was because of the work I've been doing on bug 115 to change the client to "not have a cow on sigpipe." As a result, I've been looking for broken pipe errors. Cheers, -- Shawn Walker "To err is human -- and to blame it on a computer is even more so." - Robert Orben _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
