On Sun, Jun 01, 2008 at 10:27:13PM -0500, Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-depot-9/
catalog.py:
- line 1167: why the return statement here?
repository.py:
- line 90: you'll end up with two adjacent spaces here.
- line 101: capitalize first word of sentence.
> > - line 141: I'm confused on how we might get here. It seems like no
> > matter what you do, unless you get shunted into the face code above,
> > we're going to error out of this method.
>
> I think you're right; it looks like a leftover from the old logic.
I'm still confused here. If we don't go into the face code, does this
method do anything useful other than return errors? What happens if line
142 doesn't fire? Is there any point in the code in this method from line
131 onwards?
pkginfo:
- line 28: Huh? I suppose you could simply say "all" here, but we
typically don't tag packages as being architecture neutral, even if
they are.
> > SUNWpython-cherrypy/Makefile:
> >
> > - If nothing else, your "prototype" target rule should be broken up into
> > more rules.
>
> I'm not sure what you wanted, but I have split it up and simplified it
> some more.
That's better. I'd probably go one step further and put the cherrypy build
in its own target as well. Right now, it's going to rebuild cherrypy every
single time you type make install. I'm not too annoyed by this yet, though,
so maybe I'll be nice and fix it myself sometime later.
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
