Hey Shawn, Just a few nits from me:
misc.py 233-235 & 247: I'm not sure this is doing what you intend. Passing INADDR_ANY as the addr to bind(3SOCKET) should cause the socket to be bound to all interfaces, whereas binding to localhost would only bind you to the loopback interface. 257: When you set the timeout this way, it's getting set on a per-socket basis and not globally, correct? Other than that, this looks good. Thanks for doing this. -j On Thu, Jun 05, 2008 at 01:32:44PM -0500, Shawn Walker wrote: > 2008/6/5 Shawn Walker <[EMAIL PROTECTED]>: > > 2008/6/4 Shawn Walker <[EMAIL PROTECTED]>: > >> The following webrev includes proposed fixes for the following bugs: > >> > >> 2147 depot should check port instead of showing traceback if port > >> binding fails > >> > >> webrev: > >> http://cr.opensolaris.org/~swalker/pkg-2147/ > > > > I just discovered a regression in this, by chance, and have decided to > > retract this webrev until I can resolve it. > > > > Sorry for the noise. > > I believe I have resolved the regression now. > > The webrev has been updated: > http://cr.opensolaris.org/~swalker/pkg-2147/ > > Thanks, > -- > Shawn Walker > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
