Looks good. Thanks for fixing this. -j
On Sat, Jun 07, 2008 at 07:16:00PM -0500, Shawn Walker wrote: > 2008/6/5 <[EMAIL PROTECTED]>: > > Hey Shawn, > > > > Just a few nits from me: > > > > misc.py > > > > 233-235 & 247: I'm not sure this is doing what you intend. Passing > > INADDR_ANY as the addr to bind(3SOCKET) should cause the socket to be > > bound to all interfaces, whereas binding to localhost would only bind > > you to the loopback interface. > > Mea culpa; you're right of course. Fixed. > > > 257: When you set the timeout this way, it's getting set on a per-socket > > basis and not globally, correct? > > Because I specified socket.SOL_SOCKET, yes (see "man setsockopt"). > > Updated webrev: > http://cr.opensolaris.org/~swalker/pkg-2147-2/ > > Diff from last webrev: > http://cr.opensolaris.org/~swalker/pkg-2147-2/raw_files/pkg-port.patch > > Cheers, > -- > Shawn Walker > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
